libera/#maemo-leste/ Sunday, 2023-04-09

freemangordonWizzup: dsc_: https://github.com/maemo-leste/mafw-gst-renderer/tree/wip_leste10:29
freemangordonlets work there, I am starting gio port10:30
bencohhmm, do we really want to use gst for that though?10:32
bencoh(that's the media player backend, right?)10:32
freemangordonyes, why not?10:36
freemangordonthis is gst-renderer after al10:36
freemangordon*all10:36
freemangordonlike, if we want another backend, then it will be anotherbackend-rnderer10:36
freemangordonwhat do you think should be the replacement?10:37
freemangordonIOW - what is wring with gst?10:37
freemangordon*wrong10:37
freemangordonuvos: Wizzup: shall I wait for you to review https://github.com/maemo-leste/mce/pull/58 ? I am running it on my device since yesterday, with no ill effects whatsoever11:25
Wizzupfreemangordon: let's wait for uvos to review it11:32
Wizzupand check @ mafw gst branch11:32
freemangordonI finished gio port btw11:33
freemangordonand commented out hal11:33
freemangordonbut, there is pa_ext_stream_restore2_info used11:33
Wizzupgreat, I'm just waking up11:33
Wizzupah11:33
freemangordonthe only difference is volume_is_absolute11:35
freemangordonand also this "This structure deprecate and replace the pa_ext_stream_restore_info which was not extensible. This new structure ca be extended without breaking API/ABI. "11:35
WizzupI think we have this is the volume applet too11:35
Wizzupiirc we spoke about it then too11:36
Wizzupthis is nokia only right?11:36
freemangordonand nemo too, iirc11:37
freemangordoninfo.volume_is_absolute = TRUE;11:37
freemangordonso we can replace with pa_ext_stream_restore_info IIUC11:37
freemangordonhmm?11:37
freemangordonwe have module-stream-restore loaded, right?11:38
Wizzupyes11:38
Wizzup@ loaded11:39
freemangordonok11:39
WizzupI will have to check @ if we can replace11:41
freemangordonI am replacing it11:42
freemangordonWizzup: please have a look https://github.com/maemo-leste/mafw-gst-renderer/commit/55d766c270b7195c4aeb2c4d18854a5e8091201311:45
Wizzupwhere do we replace volume is absolute here11:49
Wizzup(not saying we need atm, just wondering)11:49
Wizzupneed it11:49
Wizzupfreemangordon: commits in the branch are looking good so far11:52
freemangordonWizzup: please pull12:01
freemangordon(if you have cloned)12:01
freemangordonWizzup: here https://github.com/maemo-leste/mafw-gst-renderer/commit/55d766c270b7195c4aeb2c4d18854a5e80912013#diff-a2804cba26e6f543707523ff68613bb21ef71dc19d1e055107de3db905d17e60L43412:01
freemangordon(absolute volume)12:01
Wizzupok, pulled12:10
freemangordonWizzup: shall I start work on gst stuff too?12:20
freemangordonas there seems to be more then one12:20
freemangordon*than12:20
Wizzupfreemangordon: if you're up for it, please12:22
Wizzuplooks like you picked up steam :)12:22
freemangordonright12:22
freemangordonok, will try12:22
freemangordonWizzup: I wonder about https://github.com/maemo-leste/mafw-gst-renderer/blob/master/libmafw-gst-renderer/mafw-gst-renderer-worker.c#L180113:06
freemangordonI did grep in /usr/lib in scratchbox13:06
freemangordonthe only match is in /usr/lib/mafw-plugin/mafw-gst-renderer.so13:07
bencohfreemangordon: I'd probably leverage libmpv, but I dunno :)13:07
freemangordonbencoh: right, but that's another renderer, no?13:07
bencohyeah, it might be used as yet-another-renderer to replace gst-renderer13:08
freemangordonmhm13:08
Wizzupnot sure what the transform would do, resize?13:10
freemangordonI cannot find it in fremantle gst either13:10
Wizzupblame reveals f9d04e568a95d0589e3566d0b19ac7de6c0a25cf13:11
Wizzupbut not sure if that helps13:11
Wizzupmight need a 'deeper'/'earlier' blame13:12
Wizzup(it mentions nokia bugs)13:12
freemangordonlooks like this bug is for code styling or something13:12
Wizzupwell there is also eff18db845c7e3ffae6566747abffdeaec3dc1e813:12
Wizzupfreemangordon: yeah13:12
Wizzupbut this is fallback for when playbin2 does not exist13:13
freemangordonno13:13
freemangordonit sets it no matter playbin or playbin213:13
Wizzup>g_warning ("playbin2 failed, falling back to playbin");13:13
freemangordonand?13:14
Wizzupthat path is not hit with playbin213:14
Wizzupas far as I can see13:14
freemangordonah, right13:14
Wizzupbrb 10 mins13:14
freemangordonseems like a remnant of some very old maemo gst version13:14
freemangordonok13:14
Wizzupagreed13:40
freemangordongoing to have some rest, will continue later on13:45
Wizzup:)13:57
freemangordonWizzup: ping18:11
Wizzupfreemangordon: pong18:24
freemangordonWizzup: here https://github.com/maemo-leste/mafw-gst-renderer/blob/master/libmafw-gst-renderer/gstscreenshot.c#L4318:25
freemangordonand here https://github.com/maemo-leste/mafw-gst-renderer/blob/master/libmafw-gst-renderer/gstscreenshot.c#L6418:25
freemangordonI should set/get caps using pad, right?18:25
Wizzupinstead of on buffer?18:26
freemangordonyes, as gtk1 doe snot support caps on buffer18:26
freemangordon*gst118:26
freemangordonso I am replacing GstBuffer with GstSample almost everywhere18:27
freemangordonbut in handoff callbacks I have buffer to deal with18:27
Wizzuphm18:28
Wizzupcould it be proxy caps?18:28
Wizzupmaybe not18:28
freemangordonI am doing   g_object_set (G_OBJECT(pad), "caps", gst_sample_get_caps(sample), NULL); in  feed_fakesrc18:29
freemangordonwhere sample is of type GstSample18:29
Wizzupsorry, I don't really know :(18:29
freemangordonI am just not sure if that's the proper way to set caps on the pad18:29
WizzupI'm reading caps man page18:29
Wizzupyeah18:29
freemangordongoogle neither :)18:29
freemangordonthere seems to be couple of functions to get caps18:30
Wizzupyeah, but not to set18:31
freemangordonmhm18:31
freemangordonthere is "caps" property, but no documentation for it :)18:32
Wizzupmaybe the proxy caps18:33
freemangordonwhat is this?18:34
WizzupCheck if the given pad is set to proxy caps. This means that the default event and query handler will forward all events and queries to the internally linked pads instead of discarding them.18:34
WizzupI mean, probably not ..  :)18:34
WizzupI guess you cannot get either sides of the link of the pad as object?18:35
freemangordonummm... I have the pad itself18:36
freemangordonmaybe I don;t understand the question18:36
WizzupI tihnk I don't know what I am talking about ;)18:39
freemangordon:)18:39
freemangordonok, guests came, will continue later on18:39
freemangordonLMK if you find something useful18:39
freemangordonttyl18:39
Wizzupttyl18:40
freemangordonWizzup: Assertion 'pa_atomic_load(&(c)->_ref) >= 1' failed at pulse/ext-stream-restore.c:166, function pa_ext_stream_restore_read(). Aborting.22:35
freemangordonany idea?22:35
freemangordonugh22:43
freemangordonmafw tests mock PA22:43
freemangordonWizzup: getting there :) https://pastebin.com/c8n0ujC122:56
Wizzupfreemangordon: great :)22:58
dsc_nice :)23:23

Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!