freemangordon | Wizzup: dsc_: https://github.com/maemo-leste/mafw-gst-renderer/tree/wip_leste | 10:29 |
---|---|---|
freemangordon | lets work there, I am starting gio port | 10:30 |
bencoh | hmm, do we really want to use gst for that though? | 10:32 |
bencoh | (that's the media player backend, right?) | 10:32 |
freemangordon | yes, why not? | 10:36 |
freemangordon | this is gst-renderer after al | 10:36 |
freemangordon | *all | 10:36 |
freemangordon | like, if we want another backend, then it will be anotherbackend-rnderer | 10:36 |
freemangordon | what do you think should be the replacement? | 10:37 |
freemangordon | IOW - what is wring with gst? | 10:37 |
freemangordon | *wrong | 10:37 |
freemangordon | uvos: Wizzup: shall I wait for you to review https://github.com/maemo-leste/mce/pull/58 ? I am running it on my device since yesterday, with no ill effects whatsoever | 11:25 |
Wizzup | freemangordon: let's wait for uvos to review it | 11:32 |
Wizzup | and check @ mafw gst branch | 11:32 |
freemangordon | I finished gio port btw | 11:33 |
freemangordon | and commented out hal | 11:33 |
freemangordon | but, there is pa_ext_stream_restore2_info used | 11:33 |
Wizzup | great, I'm just waking up | 11:33 |
Wizzup | ah | 11:33 |
freemangordon | the only difference is volume_is_absolute | 11:35 |
freemangordon | and also this "This structure deprecate and replace the pa_ext_stream_restore_info which was not extensible. This new structure ca be extended without breaking API/ABI. " | 11:35 |
Wizzup | I think we have this is the volume applet too | 11:35 |
Wizzup | iirc we spoke about it then too | 11:36 |
Wizzup | this is nokia only right? | 11:36 |
freemangordon | and nemo too, iirc | 11:37 |
freemangordon | info.volume_is_absolute = TRUE; | 11:37 |
freemangordon | so we can replace with pa_ext_stream_restore_info IIUC | 11:37 |
freemangordon | hmm? | 11:37 |
freemangordon | we have module-stream-restore loaded, right? | 11:38 |
Wizzup | yes | 11:38 |
Wizzup | @ loaded | 11:39 |
freemangordon | ok | 11:39 |
Wizzup | I will have to check @ if we can replace | 11:41 |
freemangordon | I am replacing it | 11:42 |
freemangordon | Wizzup: please have a look https://github.com/maemo-leste/mafw-gst-renderer/commit/55d766c270b7195c4aeb2c4d18854a5e80912013 | 11:45 |
Wizzup | where do we replace volume is absolute here | 11:49 |
Wizzup | (not saying we need atm, just wondering) | 11:49 |
Wizzup | need it | 11:49 |
Wizzup | freemangordon: commits in the branch are looking good so far | 11:52 |
freemangordon | Wizzup: please pull | 12:01 |
freemangordon | (if you have cloned) | 12:01 |
freemangordon | Wizzup: here https://github.com/maemo-leste/mafw-gst-renderer/commit/55d766c270b7195c4aeb2c4d18854a5e80912013#diff-a2804cba26e6f543707523ff68613bb21ef71dc19d1e055107de3db905d17e60L434 | 12:01 |
freemangordon | (absolute volume) | 12:01 |
Wizzup | ok, pulled | 12:10 |
freemangordon | Wizzup: shall I start work on gst stuff too? | 12:20 |
freemangordon | as there seems to be more then one | 12:20 |
freemangordon | *than | 12:20 |
Wizzup | freemangordon: if you're up for it, please | 12:22 |
Wizzup | looks like you picked up steam :) | 12:22 |
freemangordon | right | 12:22 |
freemangordon | ok, will try | 12:22 |
freemangordon | Wizzup: I wonder about https://github.com/maemo-leste/mafw-gst-renderer/blob/master/libmafw-gst-renderer/mafw-gst-renderer-worker.c#L1801 | 13:06 |
freemangordon | I did grep in /usr/lib in scratchbox | 13:06 |
freemangordon | the only match is in /usr/lib/mafw-plugin/mafw-gst-renderer.so | 13:07 |
bencoh | freemangordon: I'd probably leverage libmpv, but I dunno :) | 13:07 |
freemangordon | bencoh: right, but that's another renderer, no? | 13:07 |
bencoh | yeah, it might be used as yet-another-renderer to replace gst-renderer | 13:08 |
freemangordon | mhm | 13:08 |
Wizzup | not sure what the transform would do, resize? | 13:10 |
freemangordon | I cannot find it in fremantle gst either | 13:10 |
Wizzup | blame reveals f9d04e568a95d0589e3566d0b19ac7de6c0a25cf | 13:11 |
Wizzup | but not sure if that helps | 13:11 |
Wizzup | might need a 'deeper'/'earlier' blame | 13:12 |
Wizzup | (it mentions nokia bugs) | 13:12 |
freemangordon | looks like this bug is for code styling or something | 13:12 |
Wizzup | well there is also eff18db845c7e3ffae6566747abffdeaec3dc1e8 | 13:12 |
Wizzup | freemangordon: yeah | 13:12 |
Wizzup | but this is fallback for when playbin2 does not exist | 13:13 |
freemangordon | no | 13:13 |
freemangordon | it sets it no matter playbin or playbin2 | 13:13 |
Wizzup | >g_warning ("playbin2 failed, falling back to playbin"); | 13:13 |
freemangordon | and? | 13:14 |
Wizzup | that path is not hit with playbin2 | 13:14 |
Wizzup | as far as I can see | 13:14 |
freemangordon | ah, right | 13:14 |
Wizzup | brb 10 mins | 13:14 |
freemangordon | seems like a remnant of some very old maemo gst version | 13:14 |
freemangordon | ok | 13:14 |
Wizzup | agreed | 13:40 |
freemangordon | going to have some rest, will continue later on | 13:45 |
Wizzup | :) | 13:57 |
freemangordon | Wizzup: ping | 18:11 |
Wizzup | freemangordon: pong | 18:24 |
freemangordon | Wizzup: here https://github.com/maemo-leste/mafw-gst-renderer/blob/master/libmafw-gst-renderer/gstscreenshot.c#L43 | 18:25 |
freemangordon | and here https://github.com/maemo-leste/mafw-gst-renderer/blob/master/libmafw-gst-renderer/gstscreenshot.c#L64 | 18:25 |
freemangordon | I should set/get caps using pad, right? | 18:25 |
Wizzup | instead of on buffer? | 18:26 |
freemangordon | yes, as gtk1 doe snot support caps on buffer | 18:26 |
freemangordon | *gst1 | 18:26 |
freemangordon | so I am replacing GstBuffer with GstSample almost everywhere | 18:27 |
freemangordon | but in handoff callbacks I have buffer to deal with | 18:27 |
Wizzup | hm | 18:28 |
Wizzup | could it be proxy caps? | 18:28 |
Wizzup | maybe not | 18:28 |
freemangordon | I am doing g_object_set (G_OBJECT(pad), "caps", gst_sample_get_caps(sample), NULL); in feed_fakesrc | 18:29 |
freemangordon | where sample is of type GstSample | 18:29 |
Wizzup | sorry, I don't really know :( | 18:29 |
freemangordon | I am just not sure if that's the proper way to set caps on the pad | 18:29 |
Wizzup | I'm reading caps man page | 18:29 |
Wizzup | yeah | 18:29 |
freemangordon | google neither :) | 18:29 |
freemangordon | there seems to be couple of functions to get caps | 18:30 |
Wizzup | yeah, but not to set | 18:31 |
freemangordon | mhm | 18:31 |
freemangordon | there is "caps" property, but no documentation for it :) | 18:32 |
Wizzup | maybe the proxy caps | 18:33 |
freemangordon | what is this? | 18:34 |
Wizzup | Check if the given pad is set to proxy caps. This means that the default event and query handler will forward all events and queries to the internally linked pads instead of discarding them. | 18:34 |
Wizzup | I mean, probably not .. :) | 18:34 |
Wizzup | I guess you cannot get either sides of the link of the pad as object? | 18:35 |
freemangordon | ummm... I have the pad itself | 18:36 |
freemangordon | maybe I don;t understand the question | 18:36 |
Wizzup | I tihnk I don't know what I am talking about ;) | 18:39 |
freemangordon | :) | 18:39 |
freemangordon | ok, guests came, will continue later on | 18:39 |
freemangordon | LMK if you find something useful | 18:39 |
freemangordon | ttyl | 18:39 |
Wizzup | ttyl | 18:40 |
freemangordon | Wizzup: Assertion 'pa_atomic_load(&(c)->_ref) >= 1' failed at pulse/ext-stream-restore.c:166, function pa_ext_stream_restore_read(). Aborting. | 22:35 |
freemangordon | any idea? | 22:35 |
freemangordon | ugh | 22:43 |
freemangordon | mafw tests mock PA | 22:43 |
freemangordon | Wizzup: getting there :) https://pastebin.com/c8n0ujC1 | 22:56 |
Wizzup | freemangordon: great :) | 22:58 |
dsc_ | nice :) | 23:23 |
Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!