| sicelo | /win 25 | 14:17 |
|---|---|---|
| Wizzup | ok, new conversations will have grouped messagesso the notifications will stack per person | 15:56 |
| Wizzup | https://wizzup.org/lockscreen.png :) | 16:54 |
| Wizzup | (oh, still copying, airplane wifi.) | 16:55 |
| Wizzup | needs some hildon-home fixes though | 16:57 |
| sicelo | we're using modified lock screen? :-) | 16:58 |
| Wizzup | sicelo: hm? | 17:03 |
| Wizzup | no | 17:03 |
| Wizzup | just hildon-home claims to accept boolean for persistent hint but it errors later on | 17:03 |
| Wizzup | so that needs fixing | 17:04 |
| freemangordon | hmm, it should | 17:16 |
| Wizzup | yeah I fixed it already | 17:17 |
| Wizzup | just saying that's all I changed | 17:17 |
| Wizzup | but now the notifications do not go away | 17:17 |
| Wizzup | and I just found outmodest does this and it made me laugh | 17:18 |
| Wizzup | out how modest* | 17:18 |
| freemangordon | hmm? | 17:21 |
| Wizzup | (plane wifi, slow to send) | 17:25 |
| Wizzup | https://github.com/maemo-leste/modest/blob/master/src/hildon2/modest-platform.c#L1750 | 17:26 |
| Wizzup | uvos: btw I checked and for the icons ot appear on the lock screen from sphone you'll just have to set some properties | 17:33 |
| Wizzup | no hildon-home changes or special handleing needed | 17:33 |
| Wizzup | afaict at least | 17:34 |
| Wizzup | you just need notify_notification_set_hint_byte and set "persistent" to TRUE | 17:34 |
| Wizzup | and then make sure that you close the notification | 17:34 |
| Wizzup | the sounds are correct :) | 17:43 |
| Wizzup | (in conversations, for sms and chat) | 17:43 |
| Wizzup | didn't have to play naything myself | 17:43 |
| Wizzup | I think this should handle vibration too | 17:45 |
| Wizzup | freemangordon: I don't remember and am in offline mode, if you get several smses from different people, do they get different notiication groups/windows? | 17:48 |
| Wizzup | (one per constant) | 17:48 |
| Wizzup | one per contact* | 17:48 |
| uvos | Wizzup: yeah because you are called "conversations" | 17:48 |
| uvos | its hardcoded per endpoint name | 17:48 |
| uvos | which is increably stupid | 17:49 |
| Wizzup | no | 17:49 |
| Wizzup | this config file does not matter I am pretty sure | 17:49 |
| Wizzup | which list are you talking about? | 17:49 |
| Wizzup | /etc/hildon-desktop/notification-groups.conf ? | 17:49 |
| Wizzup | keep in mind that conversations is not the actual name in fremantle | 17:50 |
| Wizzup | it's rtcom-message-ui or something | 17:50 |
| Wizzup | I have another 7 hours to wait, so I might look at it is there is anther hardcoded list | 17:51 |
| uvos | yes its notification-groups | 17:51 |
| uvos | to get that behavior you need to be the dbus destination it hardcodes | 17:51 |
| Wizzup | ok so I mucked around with this and restarted hidon-home nad it makes no difference | 17:51 |
| Wizzup | the word conversations does not appear in it either | 17:52 |
| Wizzup | maybe there is something I am missing | 17:52 |
| uvos | telepathy dose | 17:52 |
| Wizzup | I think what you should do in sphone is | 17:52 |
| uvos | its impossible for sphone | 17:52 |
| uvos | because sphone has no dbus interface like that | 17:52 |
| Wizzup | in notify-libnotify.c | 17:52 |
| Wizzup | change im.received to sms-message | 17:53 |
| Wizzup | and then it will make sound nad probably also vibrate | 17:53 |
| Wizzup | that is my guess at least | 17:53 |
| uvos | no it will break everything | 17:53 |
| Wizzup | ok, well this works in conversations | 17:53 |
| uvos | because h-h is then hardcoded to ask telepathy about the notifcation | 17:53 |
| Wizzup | there is no 'NotificationUI' client | 17:54 |
| Wizzup | I mean I'm happy to leave it at this but it seems to me like it should just work | 17:54 |
| uvos | then your setup is also broken | 17:54 |
| Wizzup | having looked at the hildon-home code | 17:54 |
| uvos | it works like this: h-h saves the notification | 17:54 |
| Wizzup | broken how? it works exactly like on fremantle | 17:54 |
| uvos | and restores it when its restarted | 17:54 |
| Wizzup | if you set persistent | 17:54 |
| Wizzup | yes | 17:54 |
| uvos | when the user clicks on it h-h will ask the dbus inteface (that is hardcoded) to handle the notification | 17:55 |
| uvos | which is broken | 17:55 |
| Wizzup | did you try this and run into this problem? | 17:55 |
| uvos | yes | 17:55 |
| Wizzup | weird, I don't have this problem | 17:55 |
| Wizzup | the window opens correctly | 17:55 |
| uvos | the interface is stupid | 17:55 |
| uvos | it should just use extended proparties for this | 17:56 |
| Wizzup | 'this' ? | 17:56 |
| uvos | all of the stuff in notification-groups.conf should be extenden props passed with the notification | 17:56 |
| uvos | yes the window opens correctly as long as you are clicking on the original notification | 17:56 |
| uvos | as soon as its restored its broken | 17:57 |
| Wizzup | and when you mean restarted, you mean when hildon home restarts | 17:58 |
| uvos | yes | 17:58 |
| Wizzup | when you mean restored* | 17:58 |
| Wizzup | ok, so this is regardless of stateful notifications? | 17:58 |
| uvos | yes | 17:58 |
| uvos | never mind that this whole steup prevents other applictions | 17:58 |
| uvos | like pidign or whatever from having grouped messages or vibration or a pattern | 17:59 |
| uvos | and so on | 17:59 |
| Wizzup | I am not sure how much of a practical problem this is since hildon-home doesn't often restart and a broken notification isn't the end of the world but yeah robably worth fixing | 17:59 |
| Wizzup | you can just request grouped messages | 17:59 |
| Wizzup | notification->setHintString("group", "_grouped_messages"); | 17:59 |
| uvos | this dident work at all last time i tried | 17:59 |
| uvos | well wen i first implemented it in sphone it was compealty broken | 18:00 |
| Wizzup | it workeed for me, but it groups everything together, regardless of who the message came from, so I need to figure out how to grouping works | 18:00 |
| uvos | fmg did fix several things | 18:00 |
| Wizzup | so how would persistent notifications work? | 18:01 |
| Wizzup | you still need a way to invoke/clear them | 18:01 |
| uvos | notifications are only presistent over resart if application provides x-maemo-dbus-interface or whatever as hint | 18:02 |
| uvos | the string of the hint is taken as the endpoint | 18:02 |
| Wizzup | so there's perhaps different persistence here | 18:02 |
| uvos | same as virbation, sound, lights | 18:02 |
| Wizzup | I am talking about reboot-level persistence | 18:02 |
| uvos | yes exactly | 18:02 |
| uvos | thats what i ment | 18:02 |
| uvos | h-h stores a endpoint that the application provides | 18:03 |
| Wizzup | if you set the persistent hint to '1' | 18:03 |
| uvos | and tries that to handle the notification after a restart | 18:03 |
| uvos | where the dbus endpoint id is lost | 18:03 |
| Wizzup | then it will end up in ~/.config/hildon/desktop/notifications.db | 18:03 |
| Wizzup | which are rendered btoh on the lock sreen and I assume on reboot | 18:03 |
| uvos | yes and even though presitance is a xdg prop those are broken for any application not hardcoded here | 18:04 |
| Wizzup | in the sense that there is no way to clear them | 18:04 |
| uvos | i think you can x out of them, but they are unhandled | 18:04 |
| Wizzup | if I 'x' them they remain in hte db | 18:06 |
| Wizzup | but that could be because conversations doesnt call close() on them properly | 18:06 |
| uvos | closing any notification is broken | 18:07 |
| uvos | every notificcation leaks memory | 18:07 |
| Wizzup | ? | 18:07 |
| uvos | https://github.com/maemo-leste/bugtracker/issues/639 | 18:08 |
| uvos | x just closes the window | 18:08 |
| uvos | it never tells anyone anything about this | 18:08 |
| uvos | so every app that uses notifications leaks memory | 18:08 |
| Wizzup | seems like it's worth fixing | 18:09 |
| Wizzup | I just checked and I don't think they actually clear from the db | 18:11 |
| Wizzup | (after a reboot and pressing x again) | 18:11 |
| uvos | presumably because h-h assumes that something is going to handle its dbus call | 18:12 |
| uvos | but this dosent happen | 18:12 |
| Wizzup | right | 18:12 |
| uvos | which is just broken in gerneal because persitant notifications are issued by non-maemo applications all the time | 18:12 |
| Wizzup | it doesn't seem like this would be too hard to fix | 18:14 |
| freemangordon | Wizzup: uvos has a point here, like, after restart persistent notifications will lead to notification window (yellow) being shown | 19:28 |
| freemangordon | but when you click on it, if there is no dbus interface assigned, nothing will hgappen | 19:28 |
| freemangordon | and dbus interfaces are hard-coded, which is API deficiency | 19:29 |
| freemangordon | we discussed how to fix that, but I am yet to do it | 19:29 |
| Wizzup | ok, we did discuss how to fix it? | 19:32 |
| Wizzup | ok | 19:32 |
| Wizzup | well count me as an interested party | 19:32 |
| Wizzup | I will make a pr for the hildon-home fxes I made earlier today | 19:32 |
| Wizzup | and yeah for the record I was not disputing uvos' point | 19:33 |
| Wizzup | I just found that some things work better than I expected wregardless of this hardcoded list | 19:33 |
| Wizzup | freemangordon: https://github.com/maemo-leste/hildon-home/pull/3 | 22:55 |
| Wizzup | freemangordon: oh libhildondesktop has similar code for persistence | 23:03 |
| Wizzup | and it only takes uchar | 23:03 |
| Wizzup | this is why my notifications do not get deleted | 23:03 |
| Wizzup | I'll see if I can get uchar from qt | 23:03 |
| Wizzup | uchar set from qt* | 23:04 |
Generated by irclog2html.py 2.17.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
